-
Notifications
You must be signed in to change notification settings - Fork 5.2k
chore: upgrade assets-controllers v62 #32546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade assets-controllers v62 #32546
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
❌ API Spec Test Failed. View the report here. |
Builds ready [f27905d]
UI Startup Metrics (1213 ± 72 ms)
Benchmark value 1724 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1718 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1713 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2508 exceeds gate value 2454 for chrome webpack home p95 uiStartup Sum of mean exceeds: 72ms | Sum of p95 exceeds: 54ms Sum of all benchmark exceeds: 126ms Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [e946876]
UI Startup Metrics (1233 ± 69 ms)
Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 2197 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Sum of mean exceeds: 20ms | Sum of p95 exceeds: 16ms Sum of all benchmark exceeds: 36ms Bundle size diffs [🚀 Bundle size reduced!]
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
@SocketSecurity ignore npm/@metamask/[email protected] |
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
✨ Files requiring CODEOWNER review ✨🕵️ @MetaMask/extension-privacy-reviewers
|
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [a60c507]
UI Startup Metrics (1669 ± 106 ms)
Benchmark value 1669 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1441 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1430 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 23 exceeds gate value 20 for chrome browserify home mean domInteractive Benchmark value 1128 exceeds gate value 800 for chrome browserify home mean firstPaint Benchmark value 13 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 22 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 1101 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1848 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1597 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1588 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1598 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 38 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 41 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 1252 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 36 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 1386 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1385 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 1363 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1675 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1674 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1657 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 1807ms | Sum of p95 exceeds: 2124ms Sum of all benchmark exceeds: 3931ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [4b62d2f]
UI Startup Metrics (1194 ± 55 ms)
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 91 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 1969 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1680 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1680 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1652 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 2ms | Sum of p95 exceeds: 122ms Sum of all benchmark exceeds: 124ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Upgrade assets-controller to v61 and integrate new perf updates here MetaMask/core#5761
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist