Skip to content

chore: upgrade assets-controllers v62 #32546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 14, 2025

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented May 6, 2025

Description

Upgrade assets-controller to v61 and integrate new perf updates here MetaMask/core#5761

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented May 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

❌ API Spec Test Failed. View the report here.

@sahar-fehri sahar-fehri changed the title chore: upgrade assets-controllers v61 chore: upgrade assets-controllers v62 May 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [f27905d]
UI Startup Metrics (1213 ± 72 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1213107415347212531324
load105995113486510911147
domContentLoaded105494713416410851139
domInteractive17135961627
firstPaint65695135243110751127
backgroundConnect6420279
firstReactRender19155152027
getState1466891828
initialActions001001
loadScripts813708108562846890
setupStore84303814
WebpackHomeuiStartup22221825268717523372507
load17241401223616518251928
domContentLoaded17181397223116518201923
domInteractive1711106131447
firstPaint1706334364198321
backgroundConnect329378383461
firstReactRender17453374108288359
getState214325372050
initialActions3112145
loadScripts17121396222916618131922
setupStore247283392344
FirefoxBrowserifyHomeuiStartup13301141178713114021630
load11851019156711812491449
domContentLoaded11851018156711812491449
domInteractive983919729112156
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213191202047
firstReactRender23194962346
getState84345822
initialActions001001
loadScripts11661005154311412311414
setupStore8318818613
WebpackHomeuiStartup15461365189012916171846
load13271164169411714041582
domContentLoaded13271164169411714031581
domInteractive79591231687119
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23156692442
firstReactRender36285553846
getState1054671031
initialActions002111
loadScripts13071144167811613891558
setupStore11529329819
Benchmark value 2223 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1724 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1718 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1713 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2508 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Sum of mean exceeds: 72ms | Sum of p95 exceeds: 54ms
Sum of all benchmark exceeds: 126ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -6.27 KiB (-0.12%)
  • ui: 71.39 KiB (1.02%)
  • common: -2.83 KiB (-0.03%)

@metamaskbot
Copy link
Collaborator

Builds ready [e946876]
UI Startup Metrics (1233 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1233110913956912781348
load107696012036511231189
domContentLoaded107094411976511181184
domInteractive17136881729
firstPaint68879120043510861179
backgroundConnect74253711
firstReactRender21154462136
getState1464381929
initialActions001000
loadScripts82670695162871936
setupStore85253810
WebpackHomeuiStartup21961725258618123142449
load17061356199914418161925
domContentLoaded17001352198314318071920
domInteractive171164121353
firstPaint1646639664185314
backgroundConnect349369424066
firstReactRender18755372114301359
getState164267271635
initialActions316145
loadScripts16951351198114418041909
setupStore196183192339
FirefoxBrowserifyHomeuiStartup13391175183111213891599
load11971052171311212621461
domContentLoaded11971052171311212621461
domInteractive1053725833119167
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2214151172138
firstReactRender23195772331
getState7430389
initialActions001001
loadScripts11781031169811012481379
setupStore64344610
WebpackHomeuiStartup15491381213115216401839
load13271189183413113961564
domContentLoaded13261189183313113951564
domInteractive78411271588108
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241572112461
firstReactRender36285653848
getState11427927915
initialActions102111
loadScripts13051170182013113701547
setupStore11529929826
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 2197 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 20ms | Sum of p95 exceeds: 16ms
Sum of all benchmark exceeds: 36ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -6.31 KiB (-0.12%)
  • ui: 71.39 KiB (1.02%)
  • common: -2.77 KiB (-0.03%)

@sahar-fehri sahar-fehri marked this pull request as ready for review May 12, 2025 16:36
@sahar-fehri sahar-fehri requested a review from ccharly May 12, 2025 16:36
Copy link

socket-security bot commented May 12, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​controller-utils@​11.7.0 ⏵ 11.8.095 +110075 +196 +5100
Updated@​metamask/​assets-controllers@​61.0.0 ⏵ 62.0.091 +110090 +1100 +2100

View full report

Copy link

socket-security bot commented May 12, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@sahar-fehri
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/[email protected]

@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested review from a team as code owners May 12, 2025 18:03
@metamaskbot
Copy link
Collaborator

metamaskbot commented May 12, 2025

✨ Files requiring CODEOWNER review ✨

🕵️ @MetaMask/extension-privacy-reviewers

  • privacy-snapshot.json

@sahar-fehri sahar-fehri requested a review from a team as a code owner May 13, 2025 08:56
@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

Builds ready [a60c507]
UI Startup Metrics (1669 ± 106 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup16691442201210617511847
load1440121716599315071596
domContentLoaded1429120816469314991588
domInteractive23175252332
firstPaint1127167164752214761597
backgroundConnect1356091237
firstReactRender26187082844
getState22887142941
initialActions001001
loadScripts110088913148711591252
setupStore1174751116
WebpackHomeuiStartup21851754257217523022436
load17071267215115417881968
domContentLoaded16981258214315117801912
domInteractive16115191343
firstPaint1706737960202293
backgroundConnect299176213260
firstReactRender17255356106288350
getState174387381634
initialActions316145
loadScripts16931255211915117771905
setupStore196272272134
FirefoxBrowserifyHomeuiStartup13271149174312113841583
load11811030160511712441433
domContentLoaded11811030160511712441433
domInteractive963515925108145
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211491102130
firstReactRender24195982350
getState13439340836
initialActions001001
loadScripts11611016158011712291412
setupStore74365617
WebpackHomeuiStartup16131426199713316851894
load13851220178713014631675
domContentLoaded13851219178713014631674
domInteractive83342872791122
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect251691132645
firstReactRender36305243845
getState104557929
initialActions003111
loadScripts13631203176813114441657
setupStore85203914
cc: @HowardBraham
Benchmark value 1669 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1441 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1430 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 23 exceeds gate value 20 for chrome browserify home mean domInteractive
Benchmark value 1128 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 13 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 22 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 1101 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1848 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1597 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1588 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1598 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 38 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 41 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 1252 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 36 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1386 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1385 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 1363 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1675 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1674 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1657 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 1807ms | Sum of p95 exceeds: 2124ms
Sum of all benchmark exceeds: 3931ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 24 Bytes (0%)
  • ui: -41 Bytes (0%)
  • common: 2.02 KiB (0.02%)

@sahar-fehri sahar-fehri added the needs-qa Label will automate into QA workspace label May 13, 2025
@sahar-fehri sahar-fehri removed the needs-qa Label will automate into QA workspace label May 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4b62d2f]
UI Startup Metrics (1194 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1194108614025512241293
load104495011934810741125
domContentLoaded103894611904910701120
domInteractive16135751625
firstPaint781131116939510651116
backgroundConnect84245823
firstReactRender19153731928
getState15572102029
initialActions001001
loadScripts79871192747829872
setupStore85172813
WebpackHomeuiStartup21681757250617422882428
load16831364209412917681875
domContentLoaded16761360208912817611870
domInteractive15115881338
firstPaint1626337861192284
backgroundConnect271093143650
firstReactRender18755389112301349
getState144159171532
initialActions317146
loadScripts16711358208612917571866
setupStore197294292034
FirefoxBrowserifyHomeuiStartup13321150175612513741612
load11911031154411712421457
domContentLoaded11901031154311712421456
domInteractive1014228331112149
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2713221312291
firstReactRender23195572248
getState74263811
initialActions0029301
loadScripts11661017153010612261386
setupStore74777613
WebpackHomeuiStartup15711367215916016511969
load13451169181513914371680
domContentLoaded13441168181413914371680
domInteractive83392783186131
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2615276272543
firstReactRender35295053846
getState1048491032
initialActions002111
loadScripts13221153172113314141652
setupStore10510412924
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 91 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 1969 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1680 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1680 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1652 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 122ms
Sum of all benchmark exceeds: 124ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 24 Bytes (0%)
  • ui: -41 Bytes (0%)
  • common: 2.02 KiB (0.02%)

@sahar-fehri sahar-fehri enabled auto-merge May 14, 2025 09:48
@sahar-fehri sahar-fehri added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit 38d5a84 May 14, 2025
156 checks passed
@sahar-fehri sahar-fehri deleted the chore/perf-improve-multichainBalances-and-rates branch May 14, 2025 11:02
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants